feat(FEC-10709, FEC-10712): player visibility - Auto-pause when player is out of view, Autoplay only when player is in view #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Dec 27, 2020
|
LGTM, please remove dists before merge |
|
@RoyBregman since you change the autoplay config, please make in setup transform from the old config to the new one |
Yuvalke
suggested changes
Jan 5, 2021
Yuvalke
suggested changes
Jan 5, 2021
Yuvalke
previously requested changes
Jan 5, 2021
OrenMe
reviewed
Jan 5, 2021
OrenMe
reviewed
Jan 5, 2021
OrenMe
reviewed
Jan 5, 2021
OrenMe
reviewed
Jan 5, 2021
OrenMe
reviewed
Jan 5, 2021
dan-ziv
reviewed
Jan 7, 2021
# Conflicts: # dist/kaltura-ovp-player.cjs.js # dist/kaltura-ovp-player.cjs.js.map # dist/kaltura-ovp-player.js # dist/kaltura-ovp-player.js.map # src/common/utils/setup-helpers.js # src/kaltura-player.js
OrenMe
reviewed
Jan 11, 2021
OrenMe
reviewed
Jan 11, 2021
# Conflicts: # dist/kaltura-ovp-player.cjs.js # dist/kaltura-ovp-player.cjs.js.map # dist/kaltura-ovp-player.js # dist/kaltura-ovp-player.js.map # package.json
…altura/kaltura-player-js into FEC-10709-autoPause-new-design
dan-ziv
previously approved these changes
Jan 13, 2021
yairans
previously requested changes
Jan 13, 2021
OrenMe
suggested changes
Jan 13, 2021
OrenMe
previously approved these changes
Jan 13, 2021
OrenMe
previously approved these changes
Jan 14, 2021
OrenMe
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
solves FEC-10709, FEC-10712
CheckLists