Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Shaka to fix the memory leak #396

Merged
merged 2 commits into from
Jan 10, 2021
Merged

fix: update Shaka to fix the memory leak #396

merged 2 commits into from
Jan 10, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jan 7, 2021

Description of the Changes

Issue: memory leak from Shaka lib.
Solution: upgrade Shaka lib.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: update Shaka to fix the memory leak
d634925 
Issue: memory leak from Shaka lib.
Solution: upgrade Shaka lib.
@Yuvalke Yuvalke requested a review from a team January 7, 2021 07:16
@Yuvalke Yuvalke self-assigned this Jan 7, 2021
@Yuvalke Yuvalke merged commit f6cc4dd into master Jan 10, 2021
@Yuvalke Yuvalke deleted the fix-memory-leak branch January 10, 2021 14:11
Yuvalke added a commit that referenced this pull request Jan 17, 2021
@Yuvalke
fix: update Shaka to fix the memory leak (#396)
d62e638 
Issue: memory leak from Shaka lib.
Solution: upgrade Shaka lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe