Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10872): loadMedia returns the provider response instead of the updated one #405

Merged
merged 11 commits into from
Feb 7, 2021
Merged

fix(FEC-10872): loadMedia returns the provider response instead of the updated one #405

merged 11 commits into from
Feb 7, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 31, 2021 •
edited
Loading

Description of the Changes

Since FEC-10669 loadMedia gets options which could change the media returned by the provider, but loadMedia still returns a promise holds the provider's response.
Solution: resolve the provider promise inside the callback with returning the updated object.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 31, 2021
@dan-ziv dan-ziv changed the title fix(FEC-10872 fix(FEC-10872): loadMedia returns the provider response instead of the updated one Jan 31, 2021
Yuvalke
Yuvalke previously approved these changes Jan 31, 2021
View reviewed changes
OrenMe
OrenMe previously approved these changes Jan 31, 2021
View reviewed changes
Yuvalke
Yuvalke previously approved these changes Jan 31, 2021
View reviewed changes
@dan-ziv dan-ziv requested a review from OrenMe January 31, 2021 10:51
@dan-ziv dan-ziv dismissed stale reviews from Yuvalke and OrenMe via c4dad55 January 31, 2021 10:51
@dan-ziv dan-ziv requested a review from Yuvalke January 31, 2021 10:51
yairans
yairans suggested changes Jan 31, 2021
View reviewed changes
src/kaltura-player.js Show resolved Hide resolved
yairans
yairans suggested changes Jan 31, 2021
View reviewed changes
src/kaltura-player.js Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from yairans February 2, 2021 09:02
yairans
yairans suggested changes Feb 2, 2021
View reviewed changes
test/src/kaltura-player.spec.js Outdated Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from yairans February 7, 2021 09:34
@dan-ziv dan-ziv merged commit d26013d into master Feb 7, 2021
@dan-ziv dan-ziv deleted the FEC-10872 branch February 7, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

@OrenMe OrenMe Awaiting requested review from OrenMe

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dan-ziv @OrenMe @yairans @Yuvalke