Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10541): add support on working with bidding, Prebid and IMA #412

Merged
merged 34 commits into from
Mar 15, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Feb 10, 2021

Description of the Changes

Add prebid config to Kaltura player config to allow play prebid ads via IMA plugin and play prebid ad via playAdNow API.
prebid will inject ad tag URL to ad layout config and delay the loading of playback, Prebid can get ad only once.

Solves FEC-10541

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested a review from a team February 10, 2021 08:31
@Yuvalke Yuvalke self-assigned this Feb 10, 2021
@Yuvalke Yuvalke removed the request for review from a team February 10, 2021 08:39
@Yuvalke Yuvalke requested a review from a team February 22, 2021 11:22
src/index.html Outdated Show resolved Hide resolved
src/kaltura-player.js Show resolved Hide resolved
flow-typed/types/advertising.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Show resolved Hide resolved
src/common/controllers/ads-controller.js Show resolved Hide resolved
flow-typed/types/prebid-config.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Show resolved Hide resolved
src/common/ads/prebid-manager.js Outdated Show resolved Hide resolved
src/common/ads/prebid-manager.js Show resolved Hide resolved
src/common/ads/prebid-manager.js Outdated Show resolved Hide resolved
docs/advertisement-layout-management.md Show resolved Hide resolved
position: 60,
ads: [{
url: [MID_ROLL_VAST_URL],
prebid: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add separate sample for top level config and also under play ad now section for playAdNow flow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top level config exist above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I meant add sample of all prebid config there. for all ads.

flow-typed/types/advertising.js Show resolved Hide resolved
@Yuvalke Yuvalke merged commit 0f21b24 into master Mar 15, 2021
@Yuvalke Yuvalke deleted the FEC-10541 branch March 15, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants