feat(FEC-10835): expose share to plugin #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: share configured ui from kaltura player. Solution: handle this config as plugin config.
Yuvalke
commented
Jun 17, 2021
Yuvalke
commented
Jun 17, 2021
Yuvalke
commented
Jun 17, 2021
Yuvalke
commented
Jun 20, 2021
yairans
reviewed
Jun 23, 2021
yairans
suggested changes
Jun 23, 2021
|
Can you add tests for the query params please? you can override |
yairans
previously approved these changes
Jun 24, 2021
yairans
suggested changes
Jun 24, 2021
flow-typed/types/ui-component.js
Outdated
| label: string, | ||
| presets: Array<string>, | ||
| area: string, | ||
| declare type KPUIComponent = KPPluginUIComponent & { |
There was a problem hiding this comment.
all components are plugin component? no, so seems the type is incorrect. KPUIComponentOptions?
yairans
reviewed
Jun 24, 2021
| @@ -0,0 +1,9 @@ | |||
| declare type KPPluginUIComponent = { | |||
There was a problem hiding this comment.
let's declare all in ui-component.js
yairans
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: share configured ui from kaltura player.
Solution: handle this config as plugin config.
CheckLists