Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11304): missing entryId on plugins #453

Merged
merged 4 commits into from
Jun 3, 2021
Merged

fix(FEC-11304): missing entryId on plugins #453

merged 4 commits into from
Jun 3, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jun 3, 2021

Description of the Changes

Issue:

  1. sources weren't taken for evaluation -
    setSources after configure: evaluator needs the config.source but it didn't update cause setSources called after.
    setSources before configure: sourceSelected called but entryId didn't configure yet.
  2. plugin doesn't load correctly from setMedia -
    plugin config passes throw after sources loaded and then the plugin won't load.
    Solution:
    Pass sources config to evaluation so plugin and sources will be loaded correctly.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Issue: sources wasn't taken for evaluation.
Solution: keep the logic as it was for evaluation.
@Yuvalke Yuvalke requested a review from a team June 3, 2021 10:08
@Yuvalke Yuvalke self-assigned this Jun 3, 2021
yairans
yairans previously approved these changes Jun 3, 2021
@Yuvalke Yuvalke merged commit db567aa into master Jun 3, 2021
@Yuvalke Yuvalke deleted the FEC-11304 branch June 3, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants