Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10791): Ad-Layout for live streams #459

Merged
merged 32 commits into from
Jul 19, 2021
Merged

feat(FEC-10791): Ad-Layout for live streams #459

merged 32 commits into from
Jul 19, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 22, 2021 •
edited by yairans
Loading

Description of the Changes

Support ad layout in live by every config

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Dan Ziv added 13 commits April 5, 2021 16:20
@dan-ziv dan-ziv requested a review from yairans June 22, 2021 11:58
@dan-ziv dan-ziv changed the title feat(FEC-10791): Ad-Layout for live streams feat(FEC-10791): Ad-Layout for live streams (WIP) Jun 22, 2021
@dan-ziv dan-ziv requested a review from a team June 22, 2021 12:00
yairans
yairans suggested changes Jun 22, 2021
View reviewed changes
src/common/controllers/ads-controller.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Show resolved Hide resolved
src/common/controllers/ads-controller.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Outdated Show resolved Hide resolved
src/common/controllers/ads-controller.js Outdated Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from yairans June 24, 2021 08:19
@kaltura-hooks
Copy link

Hi @dan-ziv,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@yairans yairans requested a review from OrenMe July 12, 2021 11:41
@yairans yairans changed the title feat(FEC-10791): Ad-Layout for live streams (WIP) feat(FEC-10791): Ad-Layout for live streams Jul 12, 2021
@yairans yairans merged commit ba693c1 into master Jul 19, 2021
@yairans yairans deleted the FEC-10791 branch July 19, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dan-ziv @kaltura-hooks @OrenMe @yairans