feat(FEC-10785): add support to remove ui element #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
requested review from
yairans,
Yuvalke,
OrenMe,
dan-ziv and
esakal
and removed request for
Yuvalke
5 tasks
yairans
suggested changes
Jun 22, 2021
flow-typed/types/ui-component.js
Outdated
| |}; | ||
|
|
||
| declare type KPUIRemoveComponent = {| | ||
| removeComponent?: string, |
There was a problem hiding this comment.
Suggested change
| removeComponent?: string, | |
| removeComponent: string, |
flow-typed/types/ui-component.js
Outdated
| }; | ||
| replaceComponent?: string, | ||
| presets: Array<string>, | ||
| area: string |
There was a problem hiding this comment.
move them up like before (mandatory first)
yairans
reviewed
Jun 23, 2021
src/common/ui-wrapper.js
Outdated
| let replaceComponent: KPUIAddComponent = { | ||
| label: `Remove_${component.removeComponent}`, | ||
| get: Components.Remove, | ||
| presets: component.presets.concat(), |
There was a problem hiding this comment.
To create a copy of the array
There was a problem hiding this comment.
- why copy?
- i think
[...component.presets]is clearer
There was a problem hiding this comment.
1.Copy because it seemed to me more correct. But not sure actually why not.
2. Because I'm old and I wrote it 1999 style
yairans
previously approved these changes
Jun 23, 2021
yairans
previously approved these changes
Jun 24, 2021
OrenMe
previously approved these changes
Jun 24, 2021
yairans
previously approved these changes
Jun 24, 2021
…a/kaltura-player-js into FEC-10785-removeComponent # Conflicts: # flow-typed/types/ui-component.js
yairans
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Until now it was possible to add new component or to add and replace existing components.
There was no official way to remove an existing ui component.
solves FEC-10785
changes were done also in ui repo - kaltura/playkit-js-ui#613
CheckLists