fix(FEC-11402): preview does not work - fix y position #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
approved these changes
Jul 22, 2021
5 tasks
RoyBregman
added a commit
that referenced
this pull request
Jul 27, 2021
…height (#473) Following #466, #471, #472 - code was refactored so image thumb height is taken from real image sprite. This overrides all issues regarding height miscalculations and the need for videoHeight (which is missing when casting) In addition kaltura player was passed to ThumbsManager instead of core player to fix preview image when casting as the duration when casting needs to come from cast player and not the core one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
In continue to #466 and due to some old configuration deployed to QA env which causes the thumbnail of being created by FFMPEG and not the packager, height is miscalculated by 1 pixel due to rounding differences.
Y position in Kaltura thumbnail should be 0 anyway - this is more correct and still shows the thumbnail even if there is some mismatch in the height
solves FEC-11402
CheckLists