feat(FEC-11399): allow ignoring server config #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
suggested changes
Aug 15, 2021
yairans
approved these changes
Aug 16, 2021
yairans
suggested changes
Aug 16, 2021
src/common/utils/setup-helpers.js
Outdated
| @@ -296,7 +296,11 @@ function getDefaultOptions(options: PartialKPOptionsObject): KPOptionsObject { | |||
| } | |||
| }; | |||
| Utils.Object.mergeDeep(defaultOptions, options); | |||
| defaultOptions = Utils.Object.mergeDeep({}, supportLegacyOptions(getServerUIConf()), defaultOptions); | |||
|
|
|||
| if (!options.ignoreServerConfig) { | |||
There was a problem hiding this comment.
maybe move it to provider config as this is relevant for kaltura partners only
RoyBregman
reviewed
Aug 16, 2021
docs/configuration.md
Outdated
| > | ||
| > ##### Default: `false` | ||
| > | ||
| > ##### Description: Indicates whether to stop using the server configuration. |
There was a problem hiding this comment.
Suggested change
| > ##### Description: Indicates whether to stop using the server configuration. | |
| > ##### Description: Instructs the player to ignore the server configuration. |
There was a problem hiding this comment.
Fixing in playkit-js-providers
RoyBregman
reviewed
Aug 16, 2021
RoyBregman
reviewed
Aug 16, 2021
| @@ -34,7 +35,8 @@ declare type PartialKPOptionsObject = { | |||
| playlist?: KPPlaylistObject, | |||
| dimensions?: PKDimensionsConfig, | |||
| ui?: KPUIOptionsObject, | |||
| cast?: {[key: string]: any} | |||
| cast?: {[key: string]: any}, | |||
There was a problem hiding this comment.
add viewability: KPViewabilityConfigObject,
Co-authored-by: Roy Bregman <48884909+RoyBregman@users.noreply.github.com>
This was referenced Aug 17, 2021
yairans
reviewed
Aug 17, 2021
Co-authored-by: Yair Ansbacher <yair.ansbacher@kaltura.com>
yairans
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add flag to provider configuration to allow ignoring server config.
Related PRs:
Fixes FEC-11399.
CheckLists