feat(FEC-12015): CC button for on/off subtitles #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -64,6 +65,19 @@ export default class StorageManager { | |||
| StorageWrapper.setItem(StorageManager.StorageKeys.TEXT_LANG, textTrack.language); | |||
| }); | |||
|
|
|||
| eventManager.listen(player, player.Event.UI.UI_ELEMENT_CLICKED, event => { | |||
There was a problem hiding this comment.
why do we need the event ?
There was a problem hiding this comment.
to save only when the language is selected by the user not by app config for example
JonathanTGold
previously approved these changes
Apr 11, 2022
SivanA-Kaltura
requested changes
Apr 12, 2022
| done(); | ||
| return; | ||
| } | ||
| player.dispatchEvent(new FakeEvent(player.Event.UI.UI_ELEMENT_CLICKED, {element: 'ClosedCaptions'})); |
| player.load(); | ||
| player.ready().then(() => { | ||
| try { | ||
| player.dispatchEvent(new FakeEvent(player.Event.UI.UI_ELEMENT_CLICKED, {element: 'ClosedCaptions'})); |
SivanA-Kaltura
previously approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add
showTextTrackapisave the CC selection in the storage
Solves FEC-12015
CheckLists