Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12113): Add Side Panels Management to player UI #544

Merged
merged 7 commits into from
May 12, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented May 3, 2022

Description of the Changes

Add TypeScript decorations file according to last new modern typescript spec to support TS typing for external integrating packages

Related pr:
kaltura/playkit-js-ui-managers#1
kaltura/playkit-js-ui#674

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

types.d.ts Show resolved Hide resolved
types.d.ts Outdated Show resolved Hide resolved
@JonathanTGold JonathanTGold requested a review from yairans May 9, 2022 09:32
yairans
yairans previously approved these changes May 11, 2022
@JonathanTGold JonathanTGold merged commit b3f599a into master May 12, 2022
@JonathanTGold JonathanTGold deleted the FEC-12113 branch May 12, 2022 08:58
@JonathanTGold JonathanTGold restored the FEC-12113 branch May 15, 2022 15:38
JonathanTGold added a commit to kaltura/playkit-js-ui-managers that referenced this pull request May 16, 2022
JonathanTGold added a commit to kaltura/playkit-js-ui that referenced this pull request May 16, 2022
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants