Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12113): Add Side Panels Management to player UI #547

Merged
merged 9 commits into from
May 16, 2022
Merged

fix(FEC-12113): Add Side Panels Management to player UI #547

merged 9 commits into from
May 16, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented May 15, 2022 •
edited
Loading

Description of the Changes

Add a minor fix type in TS decalcomania file

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans
yairans reviewed May 16, 2022
View reviewed changes
types.d.ts
TOP: 'top',
BOTTOM: 'bottom',
RIGHT: 'right'
LEFT: 'left';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure? this os an object no?

@JonathanTGold JonathanTGold merged commit 5ea1b5b into master May 16, 2022
@JonathanTGold JonathanTGold deleted the FEC-12113 branch May 16, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanTGold @yairans