feat: set log level from config and API #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable setting log from:
- config `{logLevel: "DEBUG"}`
- global flag `window.DEBUG_KALTURA_PLAYER`
- query stirng param: `debugKalturaPlayer`
pass config to kaltura-player and included packages: playkit, providers and UI
We will need to refactor the actual API for set and get log level as today it actualy reflects only the playkit log level
dan-ziv
suggested changes
Nov 14, 2017
| this._uiManager = new PlaykitUI(this._player, {targetId: targetId}); | ||
| this._provider = new OvpProvider(__VERSION__, config.partnerId, config.ks, config.env); | ||
| this._logger = getLogger('KalturaPlayer' + Utils.Generator.uniqueId(5)); | ||
| this._uiManager = new PlaykitUI(this._player, {targetId: targetId, logLevel: playerConfig.logLevel}); |
There was a problem hiding this comment.
Why do we need to split the configs?
We can't just do config.logLevel?
src/setup.js
Outdated
| @@ -20,6 +22,13 @@ import { | |||
| * @returns {Player} - Player | |||
| */ | |||
| function setup(targetId: string, options: Object): KalturaPlayer { | |||
| if (isDebugMode()){ | |||
There was a problem hiding this comment.
- maybe export this logic to
setLogLevelmethod as part of the setup helpers? - better to do it after the initial validation of target id and providers config?
- prettify
src/utils/logger.js
Outdated
| * @param {?string} name - the logger name | ||
| * @returns {Object} - the log level | ||
| */ | ||
| function getLogLevel(name?: string): Object{ |
src/utils/setup-helpers.js
Outdated
| * check the player debug mode according to config or URL query string params | ||
| * @returns {boolean} - if to set debug mode or not | ||
| */ | ||
| function isDebugMode(): void{ |
dan-ziv
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
enable setting log from:
{logLevel: "DEBUG"}window.DEBUG_KALTURA_PLAYERdebugKalturaPlayerpass config to kaltura-player and included packages: playkit, providers and UI
We will need to refactor the actual API for set and get log level as today it actualy reflects only the playkit log level
CheckLists