Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12735): Player v7| More plugins| Plugins inside the more plugins are not accessible #592

Merged
merged 2 commits into from
Nov 24, 2022
Merged

fix(FEC-12735): Player v7| More plugins| Plugins inside the more plugins are not accessible #592

merged 2 commits into from
Nov 24, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Nov 17, 2022 •
edited
Loading

Description of the Changes

Update TS types declarations

related pr: kaltura/playkit-js-ui-managers#16

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold mentioned this pull request Nov 17, 2022
Merged
5 tasks
@SivanA-Kaltura
Copy link
Contributor

SivanA-Kaltura commented Nov 17, 2022 •
edited by JonathanTGold
Loading

@JonathanTGold
KeyMap is already exposed statically in KalturaPlayer.ui.utils.KeyMap and is part of the type declaration in kaltura-player.d.ts

@SivanA-Kaltura
We currently have two sources for TS types declarations the new one made according to the updated TS specification and also exported
The old one is an old syntax which is not compiled with the new TS versions and also never exported properly through the package.json as declaration file should be
Note that my fix is in the new on

@JonathanTGold JonathanTGold merged commit 99af686 into master Nov 24, 2022
JonathanTGold added a commit to kaltura/playkit-js-ui-managers that referenced this pull request Nov 24, 2022
@JonathanTGold
fix(FEC-12735): Player v7| More plugins| Plugins inside the more plug…
f9f77d6 
…ins are not accessible (#16)

solves: FEC-12735

related pr: kaltura/kaltura-player-js#592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@giladna giladna Awaiting requested review from giladna

@ErezKaltura ErezKaltura Awaiting requested review from ErezKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanTGold @SivanA-Kaltura