feat(FEC-7954): poster and thumbnail preview missing on tv player #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 1, 2018 10:57
Add options to configure poster from app.
…into poster-thumbs-ott
OrenMe
previously approved these changes
Mar 12, 2018
src/ott/poster-and-thumbs.js
Outdated
| posters.forEach(picture => { | ||
| const w = picture.width; | ||
| const h = picture.height; | ||
| const widthDelta = Math.abs(w - width); |
There was a problem hiding this comment.
use pictureWidth/Height and playerWidth/Height
src/ott/poster-and-thumbs.js
Outdated
| function setPlayerDimensionsOnPoster(poster: string, width: number, height: number): string { | ||
| const parts = poster.split('/'); | ||
| for (let i = 0; i < parts.length; i++) { | ||
| if (parts[i] === 'width') { |
There was a problem hiding this comment.
try to use string.match(/width\/(\d+))
added 7 commits
March 12, 2018 16:44
…a-player-js into poster-thumbs-ott
…a-player-js into poster-thumbs-ott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
CheckLists