Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8396): media source adapters default config overrides the player supplied config #66

Merged
merged 1 commit into from
Jul 12, 2018
Merged

fix(FEC-8396): media source adapters default config overrides the player supplied config #66

merged 1 commit into from
Jul 12, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Jul 11, 2018

Description of the Changes

The merge order for the config gave default config precedence over the application supplied config

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Jul 11, 2018
@OrenMe OrenMe merged commit eec593d into master Jul 12, 2018
@OrenMe OrenMe deleted the FEC-8396 branch July 12, 2018 08:41
dan-ziv pushed a commit that referenced this pull request Jul 16, 2020
@odedhutzler
fix(FEC-8684): IE11 live dash playback is stuck (#66)
c543921 
* fixing live on ie11

cannot assign videoElement.currentTime before loadedMetadata is fired

* flow fix

* fix unit tests according to the code fix

calling the loadPromise before checking the data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odedhutzler odedhutzler odedhutzler approved these changes

@dan-ziv dan-ziv dan-ziv approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OrenMe @dan-ziv @odedhutzler