feat(FEC-11608): Provider - Expose default service Url #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanTGold
requested review from
yairans and
RoyBregman
and removed request for
yairans
RoyBregman
reviewed
Nov 11, 2021
src/k-provider/ovp/index.js
Outdated
|
|
||
| declare var __VERSION__: string; | ||
| declare var __NAME__: string; | ||
|
|
||
| const NAME = __NAME__ + '-ovp'; | ||
| const VERSION = __VERSION__; | ||
|
|
||
| export {OVPProvider as Provider, NAME, VERSION, RequestBuilder, ResponseTypes}; | ||
| export {OVPProvider as Provider, NAME, VERSION, RequestBuilder, ResponseTypes, OVPConfiguration}; |
There was a problem hiding this comment.
Suggested change
| export {OVPProvider as Provider, NAME, VERSION, RequestBuilder, ResponseTypes, OVPConfiguration}; | |
| export {OVPProvider as Provider, NAME, VERSION, RequestBuilder, ResponseTypes, OVPConfiguration as DefaultConfiguration}; |
There was a problem hiding this comment.
@RoyBregman Maybe OVPDefaultConfiguration ? to highlight that is relevant only for OVP ?
There was a problem hiding this comment.
not needed. the player is already typed. there is kaltura-ovp-player and kaltura-tv-player
JonathanTGold
changed the title
JonathanTGold
force-pushed
the
FEC-11608
branch
from
5cae090
to
b798efe
Compare
yairans
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Provider - Expose default service Url
solves FEC-11608
related pr:
kaltura/playkit-js-kaltura-cuepoints#14
CheckLists