-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-12611): Kaltura Image Entry Support - Load Kaltura Image Entries with or without KS #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2023
SivanA-Kaltura
requested changes
Jan 8, 2023
@JonathanTGold some basic unit tests i can think of:
|
5 tasks
SivanA-Kaltura
approved these changes
Jan 19, 2023
JonathanTGold
added a commit
to kaltura/playkit-js
that referenced
this pull request
Jan 19, 2023
JonathanTGold
added a commit
to kaltura/playkit-js-ui
that referenced
this pull request
Jan 19, 2023
…Render, and Playlist (#718) solves: FEC-12612 Add a new preset for image related prs: kaltura/playkit-js-image-player#1 kaltura/playkit-js-providers#190 kaltura/kaltura-player-js#598 kaltura/playkit-js#697
JonathanTGold
added a commit
to kaltura/playkit-js-image-player
that referenced
this pull request
Jan 19, 2023
…ge, with or without duration (#1) Add a new engine for support image playing solves FEC-12610 related prs: kaltura/playkit-js-providers#190 kaltura/kaltura-player-js#598 kaltura/playkit-js#697 kaltura/playkit-js-ui#718
JonathanTGold
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Jan 22, 2023
…ge, with or without duration (#598) # Description of the Changes - Auto configure the stream priority to image engine if an image source is detected - New isUntimedImage() public API (to which the playkit-js-ui is listening and sets the ui preset accordingly) - Add default duration of 5 sc for timed image items on Playlist solves FEC-12610 related prs: kaltura/playkit-js-image-player#1 kaltura/playkit-js#697 kaltura/playkit-js-providers#190 kaltura/playkit-js-ui#718
borhandarabi
pushed a commit
to TasvirChi/playchi-js-ui
that referenced
this pull request
May 15, 2024
…Render, and Playlist (#718) solves: FEC-12612 Add a new preset for image related prs: kaltura/playkit-js-image-player#1 kaltura/playkit-js-providers#190 kaltura/kaltura-player-js#598 kaltura/playkit-js#697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
solves FEC-12611
related prs:
kaltura/kaltura-player-js#598
kaltura/playkit-js#697
kaltura/playkit-js-image-player#1
kaltura/playkit-js-ui#718
CheckLists