Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12611): Kaltura Image Entry Support - Load Kaltura Image Entries with or without KS #190

Merged
merged 13 commits into from
Jan 19, 2023

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jan 1, 2023

Description of the Changes

solves FEC-12611

related prs:
kaltura/kaltura-player-js#598
kaltura/playkit-js#697
kaltura/playkit-js-image-player#1
kaltura/playkit-js-ui#718

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura self-requested a review January 8, 2023 09:22
src/entities/image-source.js Outdated Show resolved Hide resolved
src/entities/image-source.js Show resolved Hide resolved
@SivanA-Kaltura
Copy link
Collaborator

@JonathanTGold some basic unit tests i can think of:

  • check that the parser handles an image response and adds the data to the image array
  • check what happens when an entry has a poster vs an entry that doesn't have a poster

@JonathanTGold JonathanTGold merged commit e1c6ac5 into master Jan 19, 2023
@JonathanTGold JonathanTGold deleted the FEC-12611 branch January 19, 2023 12:46
JonathanTGold added a commit to kaltura/playkit-js-ui that referenced this pull request Jan 19, 2023
JonathanTGold added a commit to kaltura/playkit-js-image-player that referenced this pull request Jan 19, 2023
JonathanTGold added a commit to kaltura/kaltura-player-js that referenced this pull request Jan 22, 2023
…ge, with or without duration (#598)

# Description of the Changes

- Auto configure the stream priority to image engine if an image source is detected 
- New isUntimedImage() public API (to which the playkit-js-ui is listening and sets the ui preset accordingly)
- Add default duration of 5 sc for timed image items on Playlist


solves FEC-12610

related prs: 
kaltura/playkit-js-image-player#1
kaltura/playkit-js#697
kaltura/playkit-js-providers#190
kaltura/playkit-js-ui#718
@JonathanTGold JonathanTGold self-assigned this Jan 9, 2024
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants