Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12235): accessibility: Not possible to change items for “Language“ and “Settings“ by space key #690

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fix(FEC-12235): accessibility: Not possible to change items for “Language“ and “Settings“ by space key #690

merged 1 commit into from
Sep 7, 2022

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

Accessibility:
player allow open the internal dropdowns from “Language“ OR “Settings“ elements using space key (and not only from enter key).

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit c0b2473 into master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladna giladna giladna approved these changes

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tzipi-kaltura @giladna