Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12763): Volume slider is inaccessible for JAWS screen reader #704

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

the issue:
JAWS and NVDA screen readers wasn't able to open the volume slider by up/down arrow

the root cause:
JWAS and NVDA have default behavior for the up/down keyboard events. so it doesn't recognize our handling

the solution:
add role='application' to enable non-default behavior for keyboard events

solves FEC-12763

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Copy link
Contributor

@JonathanTGold JonathanTGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...In this mode, the web author is completely responsible for handling any and all keyboard input, focus management, and other interactions and cannot assume assistive technologies would do any processing on their end.

see here

this disables the Native browser's behaviour of this element and all of its decedents

...The application role is designed to provide a means for widgets that are not part of the standard set to be accessible for direct interaction in ATs that use both browse and focus modes for interacting with web content. Most common widgets have expected keyboard interaction behaviors. Because of this, a custom keyboard experience created by a web author would create a confusing experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants