-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-10817): expose the current time of the video element in live streams #589
Changes from 8 commits
ee5694a
2e25e2d
cee4aa9
79658ec
7c255aa
3977110
06feb00
39cf84d
4ff873a
04245e4
ff3bea8
6ed1ae0
3f00f26
e4dae06
0d3350a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -542,7 +542,7 @@ class SeekBar extends Component { | |
*/ | ||
render(props: any, state: Object): React$Element<any> { | ||
const virtualProgressWidth = `${(props.virtualTime / props.duration) * 100}%`; | ||
const progressWidth = `${(props.currentTime / props.duration) * 100}%`; | ||
const progressWidth = `${props.forceFullProgress ? 100 : (props.currentTime / props.duration) * 100}%`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now the live time is linear and duration is always bigger than the current time. For that reason you will see unfulfilled progress on the progress bar's edge. When we are on live edge this has no meaning so we would like to see full progress. |
||
const bufferedWidth = `${Math.round(this.getBufferedPercent())}%`; | ||
const seekbarStyleClass = [style.seekBar]; | ||
if (props.adBreak) seekbarStyleClass.push(style.adBreak); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,4 +96,4 @@ | |
"overlay_text": "Lecture en mode Picture-in-picture" | ||
} | ||
} | ||
}s | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
isDvr
removed? if needed so remove it from mapStateToProps as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are out-of-sync (paused for example) also on live without DVR, we would like to see indication on the live tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is new behavior. how is related to this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the calculation is different so we can support it as part of this change. Like before it's just a bug.