Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export name and version on module #13

Merged
merged 1 commit into from
Nov 8, 2017
Merged

feat: export name and version on module #13

merged 1 commit into from
Nov 8, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 7, 2017 •
edited
Loading

Description of the Changes

add export of name and version of library

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Nov 7, 2017
@OrenMe OrenMe requested a review from dan-ziv November 7, 2017 23:06
@OrenMe OrenMe mentioned this pull request Nov 7, 2017
Merged
5 tasks
@OrenMe OrenMe merged commit 8490b14 into master Nov 8, 2017
@OrenMe OrenMe deleted the eportedVars branch November 8, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@OrenMe OrenMe

Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @yairans