Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13038): Add image track type only if player sources with image is populated #136

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix(FEC-13038): Add image track type only if player sources with image is populated #136

merged 2 commits into from
Mar 15, 2023

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Mar 14, 2023 •
edited
Loading

Description of the Changes

FEC-13038

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@giladna giladna changed the title fix(FEC-13038): Add image track type only player sources with image is populated fix(FEC-13038): Add image track type only if player sources with image is populated Mar 14, 2023
@JonathanTGold JonathanTGold self-requested a review March 15, 2023 09:20
JonathanTGold
JonathanTGold suggested changes Mar 15, 2023
View reviewed changes
src/adapter/adapter.js Outdated Show resolved Hide resolved
@giladna @JonathanTGold
Update src/adapter/adapter.js
5457e07 
this.player.isImage()

Co-authored-by: JonathanTGold <62672270+JonathanTGold@users.noreply.github.com>
@giladna giladna merged commit 9a1b6b9 into master Mar 15, 2023
@giladna giladna deleted the FEC-13038 branch March 15, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@JonathanTGold JonathanTGold JonathanTGold approved these changes

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladna @JonathanTGold @lianbenjamin