Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9048): ad start is not sent for IMA DAI #30

Merged
merged 1 commit into from
May 1, 2019
Merged

fix(FEC-9048): ad start is not sent for IMA DAI #30

merged 1 commit into from
May 1, 2019

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Apr 30, 2019

Description of the Changes

IMA DAI is using the new ads framework and doesn't support the legacy IMA event model.
Added support for the new ads interface so it now supports both IMA and IMA DAI.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe requested a review from yairans April 30, 2019 14:31
@OrenMe OrenMe self-assigned this Apr 30, 2019
@OrenMe OrenMe requested a review from itaykinnrot May 1, 2019 06:33
@OrenMe OrenMe merged commit c2d3231 into master May 1, 2019
@OrenMe OrenMe deleted the FEC-9048 branch May 1, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaykinnrot itaykinnrot itaykinnrot approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @itaykinnrot