feat(FEC-11964): Allow configuring player to auto-select audio track according to browser locale #640
Conversation
…according to browser locale
| @@ -691,7 +691,7 @@ var config = { | |||
| > | |||
| > > ### config.playback.audioLanguage | |||
| > > | |||
| > > ##### Type: `string` | |||
| > > ##### Type: `string || "auto"` | |||
There was a problem hiding this comment.
you mean the default is auto ?
There was a problem hiding this comment.
no. string means language like 'en' etc. or 'auto'
There was a problem hiding this comment.
not sure I understand, "auto" is a value and not a type
There was a problem hiding this comment.
right it's a value, specific value so it's documented explicitly
There was a problem hiding this comment.
it's already in the description, why does it need to be in the type as well ?
There was a problem hiding this comment.
no special reason, just to be aligned with the text language documentation - https://github.com/kaltura/playkit-js/blob/master/docs/configuration.md#type-string--auto
src/player.js
Outdated
| * @private | ||
| * @returns {string} - The track language to set by default. | ||
| */ | ||
| _getLanguage(configuredLanguage: string, defaultTrack: ?TextTrack): string { | ||
| _getLanguage(configuredLanguage: string, defaultTrack: ?(TextTrack | AudioTrack)): string { |
There was a problem hiding this comment.
I think that writing it like in _setDefaultTrack, with a typed function and passing the tracks from outside, is cleaner than having an if inside the function.
And if we don't use language outside _setDefaultTrack anyway, you can also merge _setDefaultTrack with _getLanguage, or call _getLanguage from inside _setDefaultTrack.
src/player.js
Outdated
| @@ -2548,25 +2548,29 @@ export default class Player extends FakeEventTarget { | |||
| const activeTracks = this.getActiveTracks(); | |||
| const playbackConfig = this.config.playback; | |||
| const offTextTrack: ?Track = this._getTextTracks().find(track => TextTrack.langComparer(OFF, track.language)); | |||
| let currentOrConfiguredTextLang = this._playbackAttributesState.textLanguage || this._getLanguage(playbackConfig.textLanguage, activeTracks.text); | |||
| let currentOrConfiguredAudioLang = this._playbackAttributesState.audioLanguage || playbackConfig.audioLanguage; | |||
| let currentOrConfiguredTextLang = | |||
src/player.js
Outdated
| let currentOrConfiguredTextLang = | ||
| this._playbackAttributesState.textLanguage || | ||
| this._getLanguage<TextTrack>(this._getTextTracks(), playbackConfig.textLanguage, activeTracks.text); | ||
| let currentOrConfiguredAudioLang = |
Description of the Changes
add the option to set
playback.audioLanguage: 'auto'and compare with the locale thenSolves FEC-11964
CheckLists