Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setDefaultMarkerWidth is missed in fixing-nft branch #19

Open
kalwalt opened this issue Jan 5, 2020 · 4 comments
Open

setDefaultMarkerWidth is missed in fixing-nft branch #19

kalwalt opened this issue Jan 5, 2020 · 4 comments
Assignees
@kalwalt
Labels
bug Something isn't working code design javascript all about javascript code
Milestone
merging NFT to ar...

Comments

@kalwalt
Copy link
Owner

kalwalt commented Jan 5, 2020

i saw that setDefaultMarkerWidth is missed in fixing-nft branch compared to the actual master artoolkitx/jsartoolkit5 branch need to think if will add it again or not.
@kalwalt kalwalt added bug Something isn't working javascript all about javascript code code design labels Jan 5, 2020
@kalwalt kalwalt self-assigned this Jan 5, 2020
@kalwalt
Copy link
Owner Author

kalwalt commented Jan 7, 2020

This function was added i think for the Type definitions see https://github.com/artoolkitx/jsartoolkit5/blob/b2a6c7529777999030773e02266799390482ba2a/js/artoolkit.api.d.ts#L69

@nicolocarpignoli
Copy link
Collaborator

yes, I think we can avoid this question for now, it does not seems crucial. :)

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 7, 2020 •
edited
Loading

We can verify the typescript version in another moment. And i have no experience in this sense...

@kalwalt kalwalt reopened this Jan 25, 2020
@kalwalt
Copy link
Owner Author

kalwalt commented Jan 25, 2020

@ThorstenBux Sorry to re-open, but it seems that this is required by arStudio see this commit augmentmy-world/arStudio@3ffb203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalwalt kalwalt

Labels
bug Something isn't working code design javascript all about javascript code
Projects
None yet
Milestone
merging NFT to artoolkitx/jsartoolkit...
Development

No branches or pull requests
2 participants
@kalwalt @nicolocarpignoli