Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating typescript version with the new changes #24

Open
kalwalt opened this issue Jan 8, 2020 · 2 comments
Open

Updating typescript version with the new changes #24

kalwalt opened this issue Jan 8, 2020 · 2 comments
Assignees

Comments

@kalwalt
Copy link
Owner

kalwalt commented Jan 8, 2020

From this issue augmentmy-world/artoolkitX.js#28 (comment)
@ThorstenBux @hakandilek We should keep an eye also on the typescript version of the lib. i did some changes but not sure of these. Maybe not a prority, we can do after merging my #1 in the master of artoolkitx/jsartoolkit5 but I wish it was solved.

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 8, 2020

@hakandilek if you want to take a look at the changes this is the PR artoolkitx#86 that we will merge in the artoolkitx/jsartoolkit5 master branch, as a consequence of this my other PR #1

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 8, 2020

I did a quick test to import jsartoolkit5 as a package in a node project on locale. As It Is can''t run because it use in different part of the libs the window object, and in node Is not allowed ( we should use global instead, self Is not also friendly for node? But It Is required for the worker ).
The window objects is used in artoolkit.api.js and artoolkit.three.js libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant