Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few suggestions for improvement of SignCheck module #12

Open
ms-github opened this issue Jul 20, 2018 · 1 comment
Open

Few suggestions for improvement of SignCheck module #12

ms-github opened this issue Jul 20, 2018 · 1 comment

Comments

@ms-github
Copy link

Hi,
Please fix the following issues:

  1. In the code, SignCheck/index.js the function checkWinSync() invokes "CheckSign.exe" with command line but never captures the return error/success code from the binary. Maybe the exe wasn't written to return any. I think it would be better to return error code from CheckSign rather than just returning true or false.
  2. CheckSign.exe appears to be generated on VS2015 and compiled with dynamic linkage to CRT. Please update the actual binary to be statically compiled with CRT. VCRUNTIME140.dll will be missing by default on Win7/8.1 systems and hence the exe can't be invoked (missing dependency). This works fine on Win 10 since it has VCRT140.dll by default. Also, Win 7 x64 gets this dll after Windows update. So this should be fixed.
    c_users_ravi_appdata_local_packages_microsoft skypeapp_kzf8qxf38zg5c_localstate_08922712-2652-430d-99cd-409223b56c33
@kami4ka
Copy link
Owner

kami4ka commented Jul 20, 2018

@icevita Can you, please, take a look?

@kami4ka kami4ka assigned kami4ka and unassigned kami4ka Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kami4ka @ms-github