Default color for regular files

[imbolc]

Now it set to white: https://github.com/kamiyaa/joshuto/blob/main/config/theme.toml#L17-L18
Which makes the files invisible on white background and probably hardly visible in most light terminal themes. Would you consider not changing this color?

[Dzordzu]

Most people prefer dark theme¹. If you want, you can change the theme file to match your preferences

---

<sup>1. Sources:
- https://css-tricks.com/poll-results-light-on-dark-is-preferred/
- https://insights.stackoverflow.com/survey/2015#tech-ide
- "Dude trust me, I'm in the IT industry for many years"</sup>

[imbolc]

What I'm suggesting won't hurt dark themes. Quite the opposite - it would utilize the foreground color of a particular theme. Why would one use a theme if they don't like its colors?

I just don't see a reason behind changing specifically the foreground color. It breaks the theme settings, at least. Following this logic, shouldn't we also change the default background to black? I'm not sure if it wold please even dark themes enthusiasts :)

Aside: following your sources, the "most" you're referring to is actually 60 / 40, which I would rather put as "roughly a half" ;)

[Dzordzu]

Quite the opposite - it would utilize the foreground color of a particular theme

Oh. In that case, why not!

[DLFW]

Hi @imbolc, sorry I have to ask: Do you want to change the default color, or do you miss a configuration option?

If you don't like white, why don't you configure a different color? If you want your terminal foreground, configure reset!

Quite the opposite - it would utilize the foreground color of a particular theme.

Well, by default it's using the 'white' of my particular theme. So that's fine. I stay in my theme. The only argument is that is looks odd/is unreadable on light themes, because the default defines a foreground but no background. That might be an argument, but then - again - it only affects light themes. A good choice might be reset as the default though because the background is also not defined and 'white' - of course - has mostly no color-contrasts to common background colors.

What would be your preference? (Don't say red 😁...)

[imbolc]

Do you want to change the default color, or do you miss a configuration option?

Neither. I'm suggesting not changing the default color. For example, if you do echo foo, it uses the default color of the terminal theme, ensuring it's always visible.

[DLFW]

Ok, so you want to change the Joshuto default color for the standard file foreground to be the default terminal foreground. So, basically reset. Hm, may make sense. It's configurable already, but it will be a less annoying out-of-the-box experience for light-theme users.

Your statement

Quite the opposite - it would utilize the foreground color of a particular theme. Why would one use a theme if they don't like its colors?

confused me. This change won't help dark-theme users at all, neither would it improve their “user experience” in any way. Both, terminal foreground and “white” are matching colors from the theme and for dark-themes, there should not be any readability issue. Also, white may be nicer in many cases as it may still appear less “profane” than the terminal fg.

It's really only helping the light-theme people. Still, it's a good argument, of course.

BTW, this is kind of valid for all light colors which are used on the terminal default background. I guess for some light-themes, also yellow might be a problem.

If @kamiyaa is fine with that, I can provide a PR.

[j-lakeman]

FYI this is how I changed my theme.toml:

# Basic style, used for regular files (and also device files and FIFOs)
[regular]
fg = "default"

This way it uses the default colour provided by the terminal theme AFAIK. It works flawlessly in both light and dark terminal themes. I've tried several terminals and themes myself.

IMHO this would be a sane default to ship with joshuto @kamiyaa what do you think?