From 7ec11314d891059a5c46150754ef925a2ee906d0 Mon Sep 17 00:00:00 2001 From: Pavel Larkin Date: Tue, 5 Mar 2024 15:29:15 -0800 Subject: [PATCH] Add Kopia repository set-parameters command (#2664) * Add safecli dependency * add new flag implementations based on the safecli package for the Kopia CLI * apply go fmt Signed-off-by: pavel.larkin * Add common Kopia args and flags * Add Kopia storage core flags * Add kopia filesystem storage flags * cleanup storage tests * Add kopia GCS storage flags * add gcs flag tests * Add kopia azure storage flags * Add kopia s3 and s3 compliant storage flags * Use test.FlagSuite for storage tests * Fix typo * Add kopia CLI repository connect command * Add kopia CLI repository connect command * Add kopia CLI repository connect server command * Add kopia CLI repository set-parameters command * Fix Apply and test.Suit Signed-off-by: pavel.larkin * Remove variadic args for Common and Cache flags Signed-off-by: pavel.larkin * pkg/kopia/cli/internal/flag is implemented in the safecli@v0.0.4 now Signed-off-by: pavel.larkin * Add pkg/kopia/cli package Signed-off-by: pavel.larkin * go mod tidy Signed-off-by: pavel.larkin * Add Kopia storage helpers Signed-off-by: pavel.larkin * Implement Kopia storage Filesystem opts Signed-off-by: pavel.larkin * Add (c) headers Signed-off-by: pavel.larkin * Remove unused error Signed-off-by: pavel.larkin * Reorganize imports Signed-off-by: pavel.larkin * Add Kopia GCS storage opts Signed-off-by: pavel.larkin * Reorganize imports Signed-off-by: pavel.larkin * Add Kopia Azure storage opts Signed-off-by: pavel.larkin * Fix gcs test Signed-off-by: pavel.larkin * Add Kopia S3 and S3 compliant storage opts Signed-off-by: pavel.larkin * Add Kopia S3 and S3 compliant storage opts Signed-off-by: pavel.larkin * Cleanup tests Signed-off-by: pavel.larkin * Add Kopia repository create command Signed-off-by: pavel.larkin * Cleanup Signed-off-by: pavel.larkin * Reorganize tests Signed-off-by: pavel.larkin * Add Kopia repository connect command Signed-off-by: pavel.larkin * Add opts tests Signed-off-by: pavel.larkin * Add opts tests Signed-off-by: pavel.larkin * Convert common flags from vars to funcs Signed-off-by: pavel.larkin * Add safecli dependency * add new flag implementations based on the safecli package for the Kopia CLI * apply go fmt Signed-off-by: pavel.larkin * Fix Apply and test.Suit Signed-off-by: pavel.larkin * pkg/kopia/cli/internal/flag is implemented in the safecli@v0.0.4 now Signed-off-by: pavel.larkin * Add pkg/kopia/cli package Signed-off-by: pavel.larkin * go mod tidy Signed-off-by: pavel.larkin * Update safecli to v0.0.5 Signed-off-by: pavel.larkin * Update safecli to v0.0.6 Signed-off-by: pavel.larkin * Fix tests Signed-off-by: pavel.larkin * Add Location.IsPointInTypeSupported Signed-off-by: pavel.larkin * Add tests for Location.IsPointInTypeSupported Signed-off-by: pavel.larkin * Fix s3 options Signed-off-by: pavel.larkin * Fix s3 options Signed-off-by: pavel.larkin * Fix options to return errors for empty args Signed-off-by: pavel.larkin * Fix options to return errors for empty args Signed-off-by: pavel.larkin * Fix options to return errors for empty args Signed-off-by: pavel.larkin * Support empty prefix Signed-off-by: pavel.larkin * Support empty prefix Signed-off-by: pavel.larkin * Support empty prefix Signed-off-by: pavel.larkin * Support empty prefix Signed-off-by: pavel.larkin * Support empty argument for hostname and username options Signed-off-by: pavel.larkin * Support PIT option for Azure and S3 only Signed-off-by: pavel.larkin * Server URL option is required Signed-off-by: pavel.larkin * Fix formatting Signed-off-by: pavel.larkin * organize imports Signed-off-by: pavel.larkin * organize imports Signed-off-by: pavel.larkin * organize imports Signed-off-by: pavel.larkin * Fix s3 tests Signed-off-by: pavel.larkin --------- Signed-off-by: pavel.larkin --- pkg/kopia/cli/repository/opts.go | 7 +- .../repository/repository_set_parameters.go | 45 +++++++++++ .../repository_set_parameters_test.go | 74 +++++++++++++++++++ 3 files changed, 123 insertions(+), 3 deletions(-) create mode 100644 pkg/kopia/cli/repository/repository_set_parameters.go create mode 100644 pkg/kopia/cli/repository/repository_set_parameters_test.go diff --git a/pkg/kopia/cli/repository/opts.go b/pkg/kopia/cli/repository/opts.go index fdea7e3394..919a322208 100644 --- a/pkg/kopia/cli/repository/opts.go +++ b/pkg/kopia/cli/repository/opts.go @@ -34,9 +34,10 @@ import ( var ( cmdRepository = command.NewArgument("repository") - subcmdCreate = command.NewArgument("create") - subcmdConnect = command.NewArgument("connect") - subcmdServer = command.NewArgument("server") + subcmdCreate = command.NewArgument("create") + subcmdConnect = command.NewArgument("connect") + subcmdServer = command.NewArgument("server") + subcmdSetParameters = command.NewArgument("set-parameters") ) // optHostname creates a new option for the hostname of the repository. diff --git a/pkg/kopia/cli/repository/repository_set_parameters.go b/pkg/kopia/cli/repository/repository_set_parameters.go new file mode 100644 index 0000000000..de1ffa2299 --- /dev/null +++ b/pkg/kopia/cli/repository/repository_set_parameters.go @@ -0,0 +1,45 @@ +// Copyright 2024 The Kanister Authors. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package repository + +import ( + "time" + + "github.com/kanisterio/safecli" + + "github.com/kanisterio/kanister/pkg/kopia/cli/args" + "github.com/kanisterio/kanister/pkg/kopia/cli/internal" + "github.com/kanisterio/kanister/pkg/kopia/cli/internal/opts" + "github.com/kanisterio/kanister/pkg/log" +) + +// SetParametersArgs defines the arguments for the `kopia repository set-parameters ...` command. +type SetParametersArgs struct { + args.Common + + RetentionMode string // retention mode for supported storage backends + RetentionPeriod time.Duration // retention period for supported storage backends + + Logger log.Logger +} + +// SetParameters creates a new `kopia repository set-parameters ...` command. +func SetParameters(args SetParametersArgs) (*safecli.Builder, error) { + return internal.NewKopiaCommand( + opts.Common(args.Common), + cmdRepository, subcmdSetParameters, + optBlobRetention(args.RetentionMode, args.RetentionPeriod), + ) +} diff --git a/pkg/kopia/cli/repository/repository_set_parameters_test.go b/pkg/kopia/cli/repository/repository_set_parameters_test.go new file mode 100644 index 0000000000..bf9d460e61 --- /dev/null +++ b/pkg/kopia/cli/repository/repository_set_parameters_test.go @@ -0,0 +1,74 @@ +package repository + +import ( + "testing" + + "github.com/kanisterio/safecli" + "gopkg.in/check.v1" + + "github.com/kanisterio/kanister/pkg/kopia/cli/internal/test" +) + +func TestRepositorySetParametersCommand(t *testing.T) { check.TestingT(t) } + +// Test Repository Set Parameters command +var _ = check.Suite(test.NewCommandSuite([]test.CommandTest{ + { + Name: "repository set-parameters with default retention", + Command: func() (*safecli.Builder, error) { + args := SetParametersArgs{ + Common: common, + } + return SetParameters(args) + }, + ExpectedCLI: []string{"kopia", + "--config-file=path/kopia.config", + "--log-dir=cache/log", + "--log-level=error", + "--password=encr-key", + "repository", + "set-parameters", + }, + }, + { + Name: "repository set-parameters with custom retention args", + Command: func() (*safecli.Builder, error) { + args := SetParametersArgs{ + Common: common, + RetentionMode: retentionMode, + RetentionPeriod: retentionPeriod, + } + return SetParameters(args) + }, + ExpectedCLI: []string{"kopia", + "--config-file=path/kopia.config", + "--log-dir=cache/log", + "--log-level=error", + "--password=encr-key", + "repository", + "set-parameters", + "--retention-mode=Locked", + "--retention-period=15m0s", + }, + }, + { + Name: "repository set-parameters with custom retention mode only", + Command: func() (*safecli.Builder, error) { + args := SetParametersArgs{ + Common: common, + RetentionMode: retentionMode, + } + return SetParameters(args) + }, + ExpectedCLI: []string{"kopia", + "--config-file=path/kopia.config", + "--log-dir=cache/log", + "--log-level=error", + "--password=encr-key", + "repository", + "set-parameters", + "--retention-mode=Locked", + "--retention-period=0s", + }, + }, +}))