Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateCSISnapshotAll, RestoreCSISnapshotAll and DeleteCSISnapshotAll functions #2463

Open
laurentiusoica opened this issue Nov 7, 2023 · 8 comments

Comments

@laurentiusoica
Copy link

For datastores with multiple replicas, having the "All" alternatives for CreateCSISnapshot, RestoreCSISnapshot and DeleteCSISnapshot is useful in order to:

  1. avoid phase duplication for each of the replicas
  2. address use cases where the number of replicas for the datastore can change in Day 2. Without the "All" alternative, a blueprint update is required with each scale
  3. have a single blueprint regardless of the setup of the datastore in various environments
Copy link

github-actions bot commented Nov 7, 2023

Thanks for opening this issue 👍. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

@mlavi
Copy link
Contributor

mlavi commented Dec 7, 2023

We discussed in today's community meeting; the request is valid. However, the solution to multiply functions may not be the best way forward, a loop or an all argument could be considered.

@mlavi
Copy link
Contributor

mlavi commented Dec 21, 2023

@laurentiusoica Can we close this issue?
@viveksinghggits will also look for a loop example

@viveksinghggits
Copy link
Contributor

CreateCSISnapshot just takes a PVC name right now. https://github.com/kanisterio/kanister/blob/master/pkg/function/create_csi_snapshot.go#L77
So, even if we passe multiple PVCs from the arg to CreateCSISnapshot the function would not be able to handle that properly. We will have to change the function in such a way that it can handle space separated PVC names.

Copy link

This issue is marked as stale due to inactivity. Add a new comment to reactivate it.

@github-actions github-actions bot added the stale label Mar 22, 2024
@shuguet shuguet removed the stale label Mar 22, 2024
@viveksinghggits
Copy link
Contributor

Hi @laurentiusoica ,
Is this still relevant to you? Do you have use case to use this feature as soon as we add it, or you had a use case where you thought it would be useful in future.

@lsoica
Copy link

lsoica commented Mar 22, 2024

Without this APIs, is there a path forward for replicated services that could also dynamically scale at runtime ?

@viveksinghggits
Copy link
Contributor

The only option right now would be to take application aware backup using database specific utilities for example mysqldump etc.

@hairyhum hairyhum added accepted and removed triage labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanister
To Be Triaged
Development

No branches or pull requests

6 participants