Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using labels to enhance kanister logs context #2873

Open
hairyhum opened this issue May 7, 2024 · 1 comment · May be fixed by #2981
Open

Document using labels to enhance kanister logs context #2873

hairyhum opened this issue May 7, 2024 · 1 comment · May be fixed by #2981

Comments

@hairyhum
Copy link
Contributor

hairyhum commented May 7, 2024

Currently kanister controller includes actionset labels with prefix kanister.io/ into controller logs when logging events for actionsets. https://github.com/kanisterio/kanister/blob/master/pkg/controller/controller.go#L391

This is not documented anywhere at the moment. Would be nice addition to something like https://docs.kanister.io/tasks.html

NOTE As we move towards the new docs format, docs changes should be repeated in docs and docs_new directories.

@viveksinghggits
Copy link
Contributor

Looks good to me, while documenting we can also mention some use cases.

@kanisterio kanisterio deleted a comment from github-actions bot May 14, 2024
@mlavi mlavi removed the triage label May 23, 2024
@hairyhum hairyhum linked a pull request Jul 15, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanister
To Be Triaged
Development

Successfully merging a pull request may close this issue.

3 participants