Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to make phase always run #674

Closed
PrasadG193 opened this issue May 13, 2020 · 3 comments
Closed

Add support to make phase always run #674

PrasadG193 opened this issue May 13, 2020 · 3 comments

Comments

@PrasadG193
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Consider we have a BP where we are trying to perform backup in multiple phases. And we have last phase (say cleanup phase) which cleans up temporary artifacts that are created as a part of backup. Even If any of the phase fails, the cleanup phase should get called. So there should be a way to mark cleanup phase run always.

Describe the solution you'd like
We can add a field to phase spec (e.g alwaysRun=true/false) to toggle the behaviour

@vkamra
Copy link

vkamra commented May 13, 2020

@PrasadG193 - this would be useful - a section in the phase where we would specify this and perhaps other execution controls such as phase timeouts, retries would be a good place to put this. I know @tdmanv has discussed this.

@github-actions
Copy link
Contributor

This issue is marked as stale due to inactivity. Add a new comment to reactivate it.

@github-actions github-actions bot added the stale label Aug 11, 2022
@ihcsim
Copy link
Contributor

ihcsim commented Aug 11, 2022

Fixed by #1297.

@ihcsim ihcsim closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants