SOLID I - Finding and fixing SRP violations

[kanmaytacker]

What?
Find SRP violations in this package and refactor it to adhere to SRP.

Why?
Better understanding of SRP.
SRP helps with maintainability and extensibility of an application.

How?

• Consider moving methods to separate classes
• Abstract classes vs interface
• Add a submission link in the discussion below.

[nikhilmusale70]

Submission Link:
https://gitfront.io/r/user-8224621/hXxGAz7X5s8G/Nikhil_LLD_FindingFixingSRPViolations22/tree/src/main/java/LLD2/HomeWorks/FindingFixingSRPViolations22/

[aevibit2]

Refactored the code since:

1. Tax rate will change based on location where the book will be sold.
2. Discount rate will change based on promotional offers and festive seasons.
   Invoice class should not be affected by these factors and its sole purpose should be to calculate total price and print invoice.
3. Saving to an external file should also not be a part of invoice class since there would be IO operations involved which doesn't concern invoice class.

[sanketh2222]

tax rate is a variable right ? even if it changes whoever is creating the object of the invoice will pass the appropriate tax Rate that is applicable. Ex.

new Invoice("Book1",2,30,18); // here discount will be 30% and taxRate will be 18%. 
new Invoice("Book1",2,20,12); // here discount will be 20% and taxRate will be 12%. bought at a different location

even though discount and taxRate has changed , we dont have to change anything in the invoice class.

is there any other benefit of moving Tax and discounts into different class.

Please help me clarify the doubt

[pramodpatil812]

https://github.com/pramodpatil812/solid/tree/main/srp
@kanmaytacker Please provide your feedback on the refactored code.

[Vishalmittal06]

https://github.com/Vishalmittal06/PracticeProbs/tree/master/src/com/sclaer/lld/srp

@kanmaytacker Kindly review

[ershivanikhandelwal]

https://github.com/ershivanikhandelwal/fundamentals/tree/master/oop/code/oop/src/main/java/com/scaler/lld/questions

@kanmaytacker Please provide your feedback

[abhi93shekJha]

https://github.com/abhi93shekJha/PythonConcepts/tree/master/SOLID_Principle