-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows. Help wanted 🙏🪟 #179
Comments
I'm trying this out on a decently sized project and starting the server takes a long time. It seems that my computer's resources, however, are not being fully utilized. It might be good to look into maximizing CPU usage while the server is indexing the repo. Also, being able to exclude certain folders inside the repo folder would also be nice. |
You are able to query the repo while it's being indexed, and the most useful files are being prioritized for indexing. For this reason the intended use case is to allow you to work normally on your computer while the repo is being indexed, which is why CPU utilization is not being maximized. However maybe it would make sense to allow the user to customize this behavior |
Thanks for the tip, seems like a reasonable design choice. Edit: I'm dumb, I installed When I try to query, I'm getting an error however. It seems to think that I don't have ripgrep installed though I've ensured that I do.
Output from Is there something I'm doing wrong? |
Now that I've resolved the
|
@DeveloperPaul123 : it's because the file path in Temp fix : |
Out of curiosity, how did you resolve the ripgrep issue? I was thinking that if it wasn't detecting your ripgrep installation originally, it might be a bug in ripgrepy itself: https://github.com/securisec/ripgrepy maybe we could help them fix the problem or at least submit an issue there. Also if you used a specific workaround we could mention that in the readme of SeaGOAT |
ok, actually we have something similar here: SeaGOAT/seagoat/utils/server.py Lines 21 to 22 in 51ae32c
we can probably reuse that |
I just installed |
I have merged this, now with the latest version of SeaGOAT, the path-related error should not happen on Windows. If either of you can try it, please confirm if it works or not 🙏 #234 |
@kantord Thanks for the the fixes, things seem to be working correctly now! |
amazing! let me know if you encounter other problems. also please let me know about your use cases and whether or not you find that the results are useful for your use cases. |
Will do thanks! As for my use case, I occasionally use it to find code in my projects. I may use it in the future to help me replace code blocks or explore legacy code bases. |
At all steps, SeaGOAT is developed with the intention of guaranteeing Windows support. That being said, as I don't have a Windows device and I don't have expertise regarding Windows development workflows, I have not been able to verify that it works properly on Windows.
The main goal is to support WSL, but supporting Windows natively is also a goal if it's possible!
Help wanted!
Here is a rough checklist of the current status of Windows support:
Also, I have discovered that some of the tests are failing on Windows. So, I created a CI file specifically for Windows that only checks some of the tests that are passing without issue:
SeaGOAT/.github/workflows/test-windows.yml
Lines 56 to 58 in 1edae8e
For comparison, the Linux tests look like this:
SeaGOAT/.github/workflows/test.yml
Lines 56 to 58 in 1edae8e
The text was updated successfully, but these errors were encountered: