Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 12 #14

Closed
ipy opened this issue Mar 15, 2019 · 3 comments · Fixed by #15
Closed

Support node 12 #14

ipy opened this issue Mar 15, 2019 · 3 comments · Fixed by #15

Comments

@ipy
Copy link

ipy commented Mar 15, 2019

win-mouse uses Handle which is removed from the latest v8 version and causes build failure. Could be fixed like node-iconv did.
image

ref:
nodejs/node#25082

@fredski02
Copy link

I'm using the electron-drag npm package which uses win-mouse under the hood. I'm also getting a similar error when a npm post installer for my electron app runs electron-builder install-app-deps and I'm using node -v =10.15.3. Did you manage to get your code working on a specific node version @ipy

@ipy
Copy link
Author

ipy commented May 1, 2019

Pushed a modified version for node 12 https://github.com/ipy/win-mouse

@robatwilliams
Copy link
Contributor

Thank you, works great with Electron 5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants