Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networked-Aframe isn't syncing player positions #5

Closed
JoshuaKGoldberg opened this issue Aug 28, 2020 · 1 comment · Fixed by #17
Closed

Networked-Aframe isn't syncing player positions #5

JoshuaKGoldberg opened this issue Aug 28, 2020 · 1 comment · Fixed by #17
Assignees
@JoshuaKGoldberg
Labels
area: game runtime Improvements to the core game experience. status: accepting prs This issue is ready for a pull request. type: bug Something isn't working! Oh no!

Comments

@JoshuaKGoldberg
Copy link
Collaborator

JoshuaKGoldberg commented Aug 28, 2020 •
edited
Loading

Other players can be seen in the game room but their positions never update.

This might be due to #7. I think we'll want to settle that first.
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working! Oh no! label Aug 28, 2020
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 28, 2020
@JoshuaKGoldberg JoshuaKGoldberg added area: game runtime Improvements to the core game experience. status: accepting prs This issue is ready for a pull request. status: blocked Other work must be completed before this is tackled. and removed status: accepting prs This issue is ready for a pull request. labels Aug 28, 2020
@JoshuaKGoldberg
Copy link
Collaborator Author

Progress! I did a little digging. The Opening datachannel to ... message never gets logged on an existing client when a new client joins (or vice versa). It seems like the NAF code understands there are clients, but the WebRTC peer connection code isn't getting set up between the two.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 7, 2020
Merged
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs This issue is ready for a pull request. and removed status: blocked Other work must be completed before this is tackled. labels Sep 7, 2020
This was referenced Sep 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: game runtime Improvements to the core game experience. status: accepting prs This issue is ready for a pull request. type: bug Something isn't working! Oh no!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-implemented NAF player position syncing karaokenite/karaokenite-react
1 participant
@JoshuaKGoldberg