Replies: 1 comment 1 reply
-
Deduplicating text that way doesn't work well from what I've seen, since the sound queue processes messages asynchronously from multiple sources (chat, AddonTalk, and AddonBattleTalk). When any source produces a new message, it overwrites the last played message. I actually used to do something similar specifically with NPCAnnouncement chat messages, but I removed that in this commit since the message sources should be handling that internally. I actually removed a bunch of special message handling at some point since it was hiding several obscure bugs, but that may have accidentally introduced regressions like what you're seeing here. Do you have any specific reproduction process so I can understand when this happens now? I don't have access to an install to test things myself since I'm out of town, but it'll help for reviewing code. |
Beta Was this translation helpful? Give feedback.
-
Hello!
I've been using this extension for a while now with Polly and I love it.
There are instances, however, when the same text is read twice in a row. I've tried to circumvent this on my own by making it unable to repeat the last read text and it did resolve my issues.
I don't know if it works as intended, the way I've done it makes the plugin only play the audio the first time when talking to the same NPC multiple times - if the NPC has a single text window.
I see that the issue has been discussed in #136, if my naïve attempt is valid I can open a PR for it or try to do it in a different way.
Here is the link to my commit.
Feedback is appreciated, thanks!
Beta Was this translation helpful? Give feedback.
All reactions