Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bdist_wheel migrating into setuptools #23

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix bdist_wheel migrating into setuptools #23

merged 1 commit into from
Aug 9, 2024

Conversation

arcivanov
Copy link
Member

If setuptools>=70.1 are available - use that
Otherwise support wheel versions before and after migration

fixes #22

@coveralls
Copy link

coveralls commented Aug 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10312690153

Details

  • 5 of 10 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 86.294%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/python/wheel_axle/bdist_axle/init.py 5 10 50.0%
Totals Coverage Status
Change from base Build 9686613008: -1.0%
Covered Lines: 264
Relevant Lines: 297
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 9, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 10312419172

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 86.788%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/python/wheel_axle/bdist_axle/init.py 8 10 80.0%
Totals Coverage Status
Change from base Build 9686613008: -0.5%
Covered Lines: 267
Relevant Lines: 297
💛 - Coveralls

@arcivanov arcivanov force-pushed the issue_22 branch 3 times, most recently from e40282b to 79aced5 Compare August 9, 2024 02:28
@arcivanov
Fix bdist_wheel migrating into setuptools
2b01bc0 
If `setuptools>=70.1` are available - use that
Otherwise support `wheel` versions before and after migration

fixes #22
@arcivanov arcivanov merged commit 9044a12 into master Aug 9, 2024
439 checks passed
@arcivanov arcivanov deleted the issue_22 branch August 9, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new wheel version break wheel-axle
2 participants
@arcivanov @coveralls