Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc deprecation recommending @web/test-runner-playwright #284

Closed
trivikr opened this issue May 22, 2023 · 1 comment · Fixed by #285
Closed

Add doc deprecation recommending @web/test-runner-playwright #284

trivikr opened this issue May 22, 2023 · 1 comment · Fixed by #285
Labels
released

Comments

@trivikr
Copy link

trivikr commented May 22, 2023

Is your feature request related to a problem? Please describe.

karma has been deprecated karma-runner/karma#3846

For browser-based unit testing solutions, karma recommends Web Test Runner and jasmine-browser-runner.

There's no such deprecation notice in karma-firefox-launcher which is an extension for karma

Describe the solution you'd like

Add doc deprecation in README, recommending readers to try @web/test-runner-playwright instead.

Browser Launchers for Web Test Runner: https://modern-web.dev/docs/test-runner/browser-launchers/overview/

Describe alternatives you've considered

N/A
@birtles birtles mentioned this issue May 25, 2023
Merged
birtles added a commit that referenced this issue May 25, 2023
@birtles
chore: add deprecation notice
5af4696 
Fixes #284.
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add deprecation notice karma-runner/karma-firefox-launcher
2 participants
@karmarunnerbot @trivikr