Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Incorrect passing of option flags to phantomjs #94

Closed
kenjiqq opened this issue Jan 4, 2016 · 2 comments
Closed

Incorrect passing of option flags to phantomjs #94

kenjiqq opened this issue Jan 4, 2016 · 2 comments

Comments

@kenjiqq
Copy link

kenjiqq commented Jan 4, 2016

Hi.
With the changes in the newest version option flags passed to phantomjs no longer work. In this PR #91 it was changed so flags are added after the script file but this is wrong it needs to be before the script file.
From the phantomJS documentation:

phantomjs [options] somescript.js [arg1 [arg2 [...]]]

So using flags: ['--load-images=false'] no longer works now. It also causes a lot of out tests to actually crash if we try to use flags. I'm guessing because it's parsing the flags we use as arguments and something goes wrong.

This is also what's causing issue #92

@dignifiedquire
Copy link
Member

Thanks for the report

@dignifiedquire dignifiedquire reopened this Jan 4, 2016
dignifiedquire added a commit to dignifiedquire/karma-phantomjs-launcher that referenced this issue Jan 4, 2016
@dignifiedquire
Copy link
Member

Should be fixed in 0.2.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants