Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Exit clean on unhandledRejections. #3092

Merged
merged 1 commit into from
Aug 4, 2018

Conversation

johnjbarton
Copy link
Contributor

Add a handler for unhandledRejections, log error and disconnect all, then exit.
Also remove broken, untested rejection handler in middleware. Prior to #3064,
this block was probably unreachable; the arguments to serveStaticFile are incorrect.

Add a handler for unhandledRejections, log error and disconnect all, then exit.
Also remove broken, untested rejection handler in middleware. Prior to karma-runner#3064,
this block was probably unreachable; the arguments to serveStaticFile are incorrect.
Copy link
Contributor

@lusarz lusarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Cccording to travis commit message seems to be inappropriate :)

@johnjbarton
Copy link
Contributor Author

I think the travis problem was fixed several of my recent commits. We should see less of these now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants