Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(travis): Correct the docs to also show how to do it on Xenial #3316

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

peternewman
Copy link
Contributor

No description provided.

@peternewman
Copy link
Contributor Author

Take two, replacing #3315 with the commit message as specified too.

Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnjbarton johnjbarton merged commit f0c4677 into karma-runner:master Jun 4, 2019
@peternewman
Copy link
Contributor Author

Thanks for merging. Does this only get onto the website when you cut a new release then? The site still has the old info currently (for both 4.0 and 3.0):
https://karma-runner.github.io/4.0/plus/travis.html

@devoto13
Copy link
Collaborator

devoto13 commented Jun 5, 2019

@peternewman Deploying Updating documentation is a manual process currently. But docs in this repo are the source of truth, so it will get to the website at some point.

@peternewman
Copy link
Contributor Author

Great thanks @devoto13 , I assumed it would be GitHub pages autodeploy given the URL, or is it more involved than that? Travis can do some clever stuff now if that would work (aside from the direct deployment via GitHub):
https://docs.travis-ci.com/user/deployment/pages/

@devoto13
Copy link
Collaborator

devoto13 commented Jun 5, 2019

Rendered docs live in another repo - https://github.com/karma-runner/karma-runner.github.com, so somebody (maybe you 😄) will need to go there, run sync-docs.sh and submit a PR. Once merged it will be deployed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants