Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Login page #20

Closed
wants to merge 3 commits into from
Closed

Added Login page #20

wants to merge 3 commits into from

Conversation

chinmaym07
Copy link

What type of PR is this?

/kind feature
/kind design
/kind documentation

What this PR does / why we need it:

This PR adds newly designed Login page to the karmada dashboard.

Which issue(s) this PR fixes:
Fixes #10

Special notes for your reviewer:

  1. Login through Token method works fine, I have tested it locally.
  2. Facing some issue with Login through Kubeconfig file.

Does this PR introduce a user-facing change?:

Added newly designed Login Page UI.

@chinmaym07
Added Login Page & structure for the new generation dashboard
eba1731 
Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
@chinmaym07
Added Karmada logo, removed logs, tested token login
e408fc7 
Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 14, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot
Copy link
Collaborator

Welcome @chinmaym07! It looks like this is your first PR to karmada-io/dashboard 🎉

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 14, 2022
@RainbowMango
Copy link
Member

Facing some issue with Login through Kubeconfig file.

That's ok. We can fix that after this PR.

cc me when ready for review.

@chinmaym07
Updated Readme.md for developing dashboard locally
880b0c5 
Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
@chinmaym07 chinmaym07 marked this pull request as ready for review June 14, 2022 20:29
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2022
@chinmaym07
Copy link
Author

chinmaym07 commented Jun 14, 2022 •
edited

/assign @RainbowMango

Yes sir we can fix the login through kubeconfig file later. I have update the PR. It's ready for review
cc: @RainbowMango

@jhnine
Copy link
Contributor

jhnine commented Jun 15, 2022

What is the reason for changing the framework?

@chinmaym07
Copy link
Author

chinmaym07 commented Jun 15, 2022 •
edited

I have considered React for building the project on these points.

  • Better support for complex applications
  • JSX
  • Large community support.
  • Extensibility and scalability.
  • Good control of the data flow.
  • Light-weight architecture.
  • Fast client-side rendering.

@RainbowMango
Copy link
Member

Hi @chinmaym07

@jhnine and her team talked to me locally, they also developed some pages locally but haven't pushed to upstream. (I didn't know it before)

In order to not block both of you, I suggest putting this PR to a separate branch. You and your team go on with react approach, @jhnine and her team go on with vue approach.

Does that make sense to you? If yes, please propose a branch name to me, and I can help set up the branch.

After this, I'll call for meetings to discuss page design. Both approaches should keep the same design.

@RainbowMango
Copy link
Member

@chinmaym07 proposed ng-dashboard-react to me on slack, @jhnine does that make sense to you.
If no objections, I'll setup the branch today.

@RainbowMango
Copy link
Member

RainbowMango commented Jun 17, 2022 •
edited

@chinmaym07 I have created the branch, please help send the PR to the new-created branch ng-dashboard-react.

@chinmaym07 chinmaym07 closed this Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadapter devadapter Awaiting requested review from devadapter

@jhnine jhnine Awaiting requested review from jhnine

Assignees

@RainbowMango RainbowMango

Labels
kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lfx-mentorship] Continue dashboard developing after onboarding
4 participants
@chinmaym07 @karmada-bot @RainbowMango @jhnine