-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop update krew for release-1.7, release-1.8 #4703
Comments
RainbowMango
added
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
labels
Mar 13, 2024
This was referenced Mar 13, 2024
Instead, consider adding a tag filter to the workflow to only run on non-prerelease + v* tags. |
Yeah, I'm still thinking this. I'm not sure if it will work if add a filter something like: update-krew-index:
if: <latest release> // Not sure how to write the logic yet.
needs: release-assests
name: Update krew-index
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- name: Update new version in krew-index
uses: rajatjindal/krew-release-bot@v0.0.40 |
This was referenced Mar 28, 2024
RainbowMango
changed the title
Stop update krew for release-1.7, release-1.8, and release-1.9
Stop update krew for release-1.7, release-1.8
Mar 28, 2024
RainbowMango
removed
the
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
label
Mar 28, 2024
RainbowMango
removed
the
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
label
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added:
release-1.7
. (Stop krew update for release-1.7 #4767)release-1.8
. (Stop krew update for release-1.8 #4768)Why is this needed:
Since krew only caches the
latest
release, so we don't need to update it for v1.7.x/1.8.x releases. Otherwise, it will open an invalid PR, like kubernetes-sigs/krew-index#2809.Sample PR: #4023
The text was updated successfully, but these errors were encountered: