Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` #3621

realnumber666 · 2023-06-01T16:23:07Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Promote UT coverage

Which issue(s) this PR fixes:
Part of #3327

Does this PR introduce a user-facing change?:
NONE

Signed-off-by: rayywu <rayywu@tencent.com>

codecov-commenter · 2023-06-01T17:03:34Z

Codecov Report

Merging #3621 (e97d295) into master (6089fa3) will increase coverage by 0.95%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
+ Coverage   54.80%   55.76%   +0.95%     
==========================================
  Files         216      221       +5     
  Lines       20121    20831     +710     
==========================================
+ Hits        11028    11617     +589     
- Misses       8495     8602     +107     
- Partials      598      612      +14

Flag	Coverage Δ
unittests	`55.76% <ø> (+0.95%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

XiShanYongYe-Chang · 2023-06-02T01:23:33Z

Hi @realnumber666 Thanks~
Can you help write the title more precisely, so that the follow-up inquiry is convenient?

XiShanYongYe-Chang

Thanks, good job. A little piece of advice.

XiShanYongYe-Chang · 2023-06-05T01:39:39Z

pkg/controllers/applicationfailover/common_test.go

+func TestNewWorkloadUnhealthyMap(t *testing.T) {
+	m := newWorkloadUnhealthyMap()
+	expected := &workloadUnhealthyMap{
+		workloadUnhealthy: make(map[types.NamespacedName]map[string]metav1.Time),
+	}
+	assert.Equal(t, expected, m)
+}


I see that this test will be overwritten by other tests. Can we consider removing it?

…failover_controller.go Signed-off-by: rayywu <rayywu@tencent.com>

XiShanYongYe-Chang

Thanks
/lgtm

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

RainbowMango

/approve

karmada-bot · 2023-06-05T12:56:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot · 2023-06-05T12:56:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot · 2023-06-05T12:56:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot · 2023-06-05T12:56:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot · 2023-06-05T12:56:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot · 2023-06-05T12:56:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot · 2023-06-05T12:56:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango · 2023-06-05T12:58:56Z

Sorry for the junk replies... That is due to GitHub was slow respond and I clicked multiple times submit...

XiShanYongYe-Chang · 2023-06-06T03:33:17Z

There is an occasional error, I have raised an issue to record it #3640 and ask @RainbowMango to help rerun the test.
/cc @RainbowMango

RainbowMango · 2023-06-06T03:38:02Z

Done.

realnumber666 added 2 commits June 1, 2023 20:33

Add UT for pkg/controllers/status/crb_status_controller.go

0ee9be3

Signed-off-by: rayywu <rayywu@tencent.com>

Add UT for pkg/controllers/status/rb_status_controller.go

8e0f186

Signed-off-by: rayywu <rayywu@tencent.com>

karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 1, 2023

karmada-bot requested review from Garrybest and pigletfly June 1, 2023 16:23

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2023

Add UT for pkg/controllers/applicationfailover/common.go

e97d295

Signed-off-by: rayywu <rayywu@tencent.com>

realnumber666 force-pushed the add-ut/crb_status_controller branch from 0ea632f to e97d295 Compare June 1, 2023 16:27

XiShanYongYe-Chang reviewed Jun 5, 2023

View reviewed changes

karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2023

realnumber666 changed the title ~~Add ut for 3 files~~ Add ut for pkg/controllers/applicationfailover and pkg/controllers/status Jun 5, 2023

Add UT for crb_application_failover_controller.go and rb_application_…

7864e11

…failover_controller.go Signed-off-by: rayywu <rayywu@tencent.com>

realnumber666 force-pushed the add-ut/crb_status_controller branch from 0170021 to 7864e11 Compare June 5, 2023 12:30

XiShanYongYe-Chang reviewed Jun 5, 2023

View reviewed changes

karmada-bot assigned XiShanYongYe-Chang Jun 5, 2023

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023

RainbowMango approved these changes Jun 5, 2023

View reviewed changes

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023

RainbowMango approved these changes Jun 5, 2023

View reviewed changes

karmada-bot requested a review from RainbowMango June 6, 2023 03:33

karmada-bot merged commit 527efd1 into karmada-io:master Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` #3621

Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` #3621

realnumber666 commented Jun 1, 2023

codecov-commenter commented Jun 1, 2023

XiShanYongYe-Chang commented Jun 2, 2023

XiShanYongYe-Chang left a comment

XiShanYongYe-Chang Jun 5, 2023

XiShanYongYe-Chang left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

RainbowMango left a comment

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

RainbowMango commented Jun 5, 2023

XiShanYongYe-Chang commented Jun 6, 2023

RainbowMango commented Jun 6, 2023

Add ut for pkg/controllers/applicationfailover and pkg/controllers/status #3621

Add ut for pkg/controllers/applicationfailover and pkg/controllers/status #3621

Conversation

realnumber666 commented Jun 1, 2023

codecov-commenter commented Jun 1, 2023

Codecov Report

XiShanYongYe-Chang commented Jun 2, 2023

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

XiShanYongYe-Chang Jun 5, 2023

Choose a reason for hiding this comment

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

karmada-bot commented Jun 5, 2023

RainbowMango commented Jun 5, 2023

XiShanYongYe-Chang commented Jun 6, 2023

RainbowMango commented Jun 6, 2023

Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` #3621

Add ut for `pkg/controllers/applicationfailover` and `pkg/controllers/status` #3621