Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent CI from fast fail when just one k8s version e2e failed #4427

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind flake

What this PR does / why we need it:

We now run e2e test on multi releases version of Kubernetes, if e2e test failed at just one releases version, the other e2e test will be interrupted by fast fail strategy.

It is not conducive to check the root cause of failure, so it is advised to disable fast fail strategy.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Dec 15, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3482ee8) 51.91% compared to head (ea808d6) 51.88%.
Report is 24 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4427      +/-   ##
==========================================
- Coverage   51.91%   51.88%   -0.04%     
==========================================
  Files         243      243              
  Lines       24146    24165      +19     
==========================================
+ Hits        12536    12537       +1     
- Misses      10928    10946      +18     
  Partials      682      682              
Flag Coverage Δ
unittests 51.88% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

I don't quite understand why disabling fail-fast can make it easier to quickly locate problems. Can you explain the reason a little bit?

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@karmada-bot karmada-bot merged commit 21b2842 into karmada-io:master Dec 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants