Only update krew index for latest stable version. #5224

liangyuanpeng · 2024-07-18T08:31:40Z

What type of PR is this?

/kind cleanup
What this PR does / why we need it:

Only update krew index for latest stable version. Avoid sending noisy PRs and in the future,we don't need some PR anymore like:

Stop krew update for release-1.7 #4767

/cc @RainbowMango @zhzhuang-zju

Which issue(s) this PR fixes:

Ref #4703
Fixes #

Special notes for your reviewer:

Tested on my fork repo:

https://github.com/liangyuanpeng/karmada/actions/runs/9987870100/job/27603262187 (release v1.10.2,running the step Update krew index)
https://github.com/liangyuanpeng/karmada/actions/runs/9987694858 (release v1.99.3, skip the stepUpdate krew index due to karmada latest stable version is v1.10.2 and not v1.99.3 )

Does this PR introduce a user-facing change?:

NONE

codecov-commenter · 2024-07-18T08:47:36Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.47%. Comparing base (a61d36a) to head (31177dd).
Report is 30 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
+ Coverage   31.14%   31.47%   +0.33%     
==========================================
  Files         640      643       +3     
  Lines       44417    44436      +19     
==========================================
+ Hits        13833    13987     +154     
+ Misses      29583    29423     -160     
- Partials     1001     1026      +25

Flag	Coverage Δ
unittests	`31.47% <ø> (+0.33%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhzhuang-zju · 2024-07-18T08:54:28Z

@liangyuanpeng What a coincidence, we must have been on the same wavelength!
Thanks for your job, and review is ongoing~

liangyuanpeng · 2024-08-28T15:57:24Z

ping @zhzhuang-zju for review :)

zhzhuang-zju · 2024-08-29T02:15:29Z

/assign

zhzhuang-zju · 2024-08-29T02:32:22Z

/lgtm
cc @RainbowMango

.github/workflows/release.yml

RainbowMango · 2024-08-30T02:04:47Z

.github/workflows/release.yml

  update-krew-index:
-    needs: release-assests
+    needs: 
+    - release-assests
+    - get-stable-tag
+    if: needs.get-stable-tag.outputs.stableTag == github.event.release.tag_name


Is it possible to get the latest tag at the update-krew-index job? So that we don't need another job.

krew-release-bot action don't care the version #5224 (comment)

It is possible to do this using the krew-release-bot binary instead of the krew-release-bot action https://github.com/rajatjindal/krew-release-bot/blob/ad6e92e6daadabfedaa107ce5186a82d41229ef1/examples/circleci.yml#L17-L18, but that means we'll be dropping the automatic updates for rajatjindal/krew-release-bot action, I'd update it if that's what you want.

then it will be:

update-krew-index: gh api.... // check is it the latest version curl -LO https://github.com/rajatjindal/krew-release-bot/releases/download/${KREW_RELEASE_BOT_VERSION}/krew-release-bot_${KREW_RELEASE_BOT_VERSION}_linux_amd64.tar.gz tar -xvf krew-release-bot_${KREW_RELEASE_BOT_VERSION}_linux_amd64.tar.gz ./krew-release-bot action

But I'd go with adding a job, it's not a big deal.

We can wait and see how upstream reply.

I didn't mean to hack anything of rajatjindal/krew-release-bot, I mean adding an extra step to the update-krew-index job, so that we don't need to share the variable between jobs.

Thanks for your clarify, i have update it , add a step and not a new job.

NOTE: have not test yet.

RainbowMango

Looks much better now.

RainbowMango · 2024-08-30T10:21:31Z

.github/workflows/release.yml

    - uses: actions/checkout@v4
+      if: steps.check-latest.outputs.stableTag == github.event.release.tag_name


Maybe we don't need to check out the code.

it's not true, krew-release-bot need the file of https://github.com/karmada-io/karmada/blob/master/.krew.yaml , https://github.com/rajatjindal/krew-release-bot?tab=readme-ov-file#basic-setup

OK, then keep it.

.github/workflows/release.yml

Signed-off-by: Lan Liang <gcslyp@gmail.com>

RainbowMango · 2024-08-31T01:26:16Z

/retest

RainbowMango

/lgtm
/approve

karmada-bot · 2024-08-31T02:11:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.github/workflows/OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango · 2024-08-31T12:17:37Z

.github/workflows/release.yml

    - uses: actions/checkout@v4
+      if: steps.get-latest-tag.outputs.latestTag == github.event.release.tag_name
    - name: Update new version in krew-index
+      if: steps.get-latest-tag.outputs.latestTag == github.event.release.tag_name


The two steps were skipped, I don't know if this workflow could get the right latest tag, maybe there is a syntax error?
https://github.com/karmada-io/karmada/actions/runs/10645084310/job/29510560441#step:3:3

I can get the latest tag on my side.

# gh api repos/karmada-io/karmada/releases/latest | jq -r '.tag_name' v1.11.0

karmada-bot requested review from RainbowMango and zhzhuang-zju July 18, 2024 08:31

karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2024

liangyuanpeng force-pushed the update_krew_stable branch 3 times, most recently from 88e63a1 to 34e2cf2 Compare July 18, 2024 08:36

liangyuanpeng force-pushed the update_krew_stable branch from 34e2cf2 to 26da63c Compare August 28, 2024 15:56

karmada-bot assigned zhzhuang-zju Aug 29, 2024

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024

RainbowMango reviewed Aug 29, 2024

View reviewed changes

.github/workflows/release.yml Outdated Show resolved Hide resolved

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024

liangyuanpeng force-pushed the update_krew_stable branch from b68cc77 to 3975092 Compare August 29, 2024 14:46

RainbowMango reviewed Aug 30, 2024

View reviewed changes

liangyuanpeng force-pushed the update_krew_stable branch from 5d6e5e8 to 939c1a4 Compare August 30, 2024 14:26

Only update krew index for latest stable version.

31177dd

Signed-off-by: Lan Liang <gcslyp@gmail.com>

liangyuanpeng force-pushed the update_krew_stable branch from 0d82401 to 31177dd Compare August 30, 2024 14:29

RainbowMango approved these changes Aug 31, 2024

View reviewed changes

karmada-bot assigned RainbowMango Aug 31, 2024

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2024

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2024

karmada-bot merged commit 96f5149 into karmada-io:master Aug 31, 2024
12 checks passed

pulsarsigs-bot deleted the update_krew_stable branch August 31, 2024 02:12

RainbowMango added this to the v1.11 milestone Aug 31, 2024

RainbowMango reviewed Aug 31, 2024

View reviewed changes

RainbowMango mentioned this pull request Oct 31, 2024

Stop bump krew for release-1.10 #5764

Merged

RainbowMango mentioned this pull request Nov 11, 2024

build(deps): bump rajatjindal/krew-release-bot from 0.0.46 to 0.0.47 #5800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only update krew index for latest stable version. #5224

Only update krew index for latest stable version. #5224

liangyuanpeng commented Jul 18, 2024 •

edited

Loading

codecov-commenter commented Jul 18, 2024 •

edited

Loading

zhzhuang-zju commented Jul 18, 2024

liangyuanpeng commented Aug 28, 2024

zhzhuang-zju commented Aug 29, 2024

zhzhuang-zju commented Aug 29, 2024

RainbowMango Aug 30, 2024

liangyuanpeng Aug 30, 2024 •

edited

Loading

liangyuanpeng Aug 30, 2024 •

edited

Loading

RainbowMango Aug 30, 2024

liangyuanpeng Aug 30, 2024

RainbowMango left a comment

RainbowMango Aug 30, 2024

liangyuanpeng Aug 30, 2024

RainbowMango Aug 31, 2024

RainbowMango commented Aug 31, 2024

RainbowMango left a comment

karmada-bot commented Aug 31, 2024

RainbowMango Aug 31, 2024

		- uses: actions/checkout@v4
		if: steps.check-latest.outputs.stableTag == github.event.release.tag_name

Only update krew index for latest stable version. #5224

Only update krew index for latest stable version. #5224

Conversation

liangyuanpeng commented Jul 18, 2024 • edited Loading

codecov-commenter commented Jul 18, 2024 • edited Loading

Codecov Report

zhzhuang-zju commented Jul 18, 2024

liangyuanpeng commented Aug 28, 2024

zhzhuang-zju commented Aug 29, 2024

zhzhuang-zju commented Aug 29, 2024

RainbowMango Aug 30, 2024

Choose a reason for hiding this comment

liangyuanpeng Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

liangyuanpeng Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

RainbowMango Aug 30, 2024

Choose a reason for hiding this comment

liangyuanpeng Aug 30, 2024

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango Aug 30, 2024

Choose a reason for hiding this comment

liangyuanpeng Aug 30, 2024

Choose a reason for hiding this comment

RainbowMango Aug 31, 2024

Choose a reason for hiding this comment

RainbowMango commented Aug 31, 2024

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Aug 31, 2024

RainbowMango Aug 31, 2024

Choose a reason for hiding this comment

liangyuanpeng commented Jul 18, 2024 •

edited

Loading

codecov-commenter commented Jul 18, 2024 •

edited

Loading

liangyuanpeng Aug 30, 2024 •

edited

Loading

liangyuanpeng Aug 30, 2024 •

edited

Loading