Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm index for v1.10.0 and v1.11.0 #5579

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add helm index for v1.10.0 and v1.11.0 #5579

merged 1 commit into from
Oct 4, 2024

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Sep 21, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add helm index for v1.10.0 and v1.11.0

these two new version can't be searched by helm, as you see:

$ helm search repo karmada-charts -l
NAME                            CHART VERSION   APP VERSION     DESCRIPTION                      
karmada-charts/karmada          v1.9.0          latest          A Helm chart for karmada         
karmada-charts/karmada          v1.8.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.7.1          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.7.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.6.2          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.6.1          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.6.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.5.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.4.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.3.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.2.2          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.2.1          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada          v1.2.0          v1.1.0          A Helm chart for karmada         
karmada-charts/karmada-operator v1.8.0          v1.1.0          A Helm chart for karmada-operator

Which issue(s) this PR fixes:

Fixes part of #5484

Special notes for your reviewer:

  1. generate methods: helm: index 1.7 #4051 (comment)

  2. test report on my local branch:

$ helm repo add my-branch-karmada https://raw.githubusercontent.com/chaosi-zju/karmada/chart-index/charts
"my-branch-karmada" has been added to your repositories

$ helm repo list        
NAME                            URL                                                                    
...
my-branch-karmada               https://raw.githubusercontent.com/chaosi-zju/karmada/chart-index/charts

$ helm search repo my-branch-karmada -l
NAME                                    CHART VERSION   APP VERSION     DESCRIPTION                      
my-branch-karmada/karmada               v1.11.0         v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.10.0         v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.9.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.8.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.7.1          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.7.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.6.2          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.6.1          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.6.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.5.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.4.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.3.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.2.2          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.2.1          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada               v1.2.0          v1.1.0          A Helm chart for karmada         
my-branch-karmada/karmada-operator      v1.11.0         v1.1.0          A Helm chart for karmada-operator
my-branch-karmada/karmada-operator      v1.10.0         v1.1.0          A Helm chart for karmada-operator
my-branch-karmada/karmada-operator      v1.9.0          v1.1.0          A Helm chart for karmada-operator
my-branch-karmada/karmada-operator      v1.8.0          v1.1.0          A Helm chart for karmada-operator

Does this PR introduce a user-facing change?:

`Helm chart`: Added helm index for v1.10.0 and v1.11.0 release.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 21, 2024
@karmada-bot karmada-bot requested review from jrkeen and pidb September 21, 2024 07:31
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 21, 2024
@chaosi-zju chaosi-zju mentioned this pull request Sep 21, 2024
Closed
5 tasks
@chaosi-zju
Copy link
Member Author

/cc @a7i @zhzhuang-zju can you help checking?

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.88%. Comparing base (21c18eb) to head (a8d71d0).
Report is 22 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5579      +/-   ##
==========================================
+ Coverage   33.91%   34.88%   +0.96%     
==========================================
  Files         645      645              
  Lines       44857    44833      -24     
==========================================
+ Hits        15215    15638     +423     
+ Misses      28484    27990     -494     
- Partials     1158     1205      +47
Flag Coverage Δ
unittests 34.88% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RainbowMango
RainbowMango reviewed Sep 23, 2024
View reviewed changes
charts/index.yaml Outdated Show resolved Hide resolved
@chaosi-zju
Add helm index for v1.10.0 and v1.11.0
a8d71d0 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@chaosi-zju
Copy link
Member Author

chaosi-zju commented Sep 24, 2024 •
edited
Loading

BTW, do we need to keep so many versions in the helm list?

We may don't expect users to use the too old version, how about keep just five latest major versions in helm list? @RainbowMango

@chaosi-zju
Copy link
Member Author

can this move forward? @RainbowMango

@a7i
Copy link
Contributor

a7i commented Sep 26, 2024

this is pretty easy to automate, if you're still up for it. looks what we've done on the Descheduler side: https://github.com/kubernetes-sigs/descheduler/tree/gh-pages

@chaosi-zju
Copy link
Member Author

this is pretty easy to automate, if you're still up for it. looks what we've done on the Descheduler side: https://github.com/kubernetes-sigs/descheduler/tree/gh-pages

do you mean we don't need manually submit this PR, the PR can be auto generated? I didn't get how to achieve it by refering https://github.com/kubernetes-sigs/descheduler/tree/gh-pages, can you teach me?

RainbowMango
RainbowMango approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

It would be great if we could automate it.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@karmada-bot karmada-bot merged commit 6b18b6e into karmada-io:master Oct 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@jrkeen jrkeen Awaiting requested review from jrkeen

@pidb pidb Awaiting requested review from pidb

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chaosi-zju @codecov-commenter @a7i @karmada-bot @RainbowMango @zhzhuang-zju